configure bundle analyzer #2836
Conversation
trajan0x
requested review from
bigboydiamonds,
abtestingalpha,
aureliusbtc,
Defi-Moses and
ChiTimesChi
as code owners
WalkthroughThe latest updates primarily focus on integrating Codecov for enhanced code coverage reporting and build analytics. Key changes include the addition of Changes
Poem
Tip AI model upgrade
|
github-actions
bot
added
M-ci
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
@codecov/webpack-plugintodocs/bridge/docusaurus.config.tsfor bundle analysis - Introduced
@codecov/webpack-plugindependency indocs/bridge/package.json - Configured
@codecov/webpack-plugininpackages/explorer-ui/next.config.js - Added
@codecov/rollup-plugintopackages/sdk-router/package.json - Updated
packages/widget/rollup.config.jsto includecodecovRollupPluginfor bundle analysis
15 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (18)
- .github/workflows/lerna.yaml (1 hunks)
- .github/workflows/packages.yml (1 hunks)
- .github/workflows/ui-preview.yaml (1 hunks)
- docs/bridge/docusaurus.config.ts (2 hunks)
- docs/bridge/package.json (1 hunks)
- packages/contracts-rfq/package.json (1 hunks)
- packages/explorer-ui/next.config.js (2 hunks)
- packages/explorer-ui/package.json (2 hunks)
- packages/rest-api/package.json (1 hunks)
- packages/sdk-router/package.json (1 hunks)
- packages/sdk-router/tsdx.config.js (1 hunks)
- packages/solidity-devops/package.json (1 hunks)
- packages/synapse-constants/package.json (1 hunks)
- packages/synapse-constants/webpack.config.js (2 hunks)
- packages/synapse-interface/next.config.js (2 hunks)
- packages/synapse-interface/package.json (1 hunks)
- packages/widget/package.json (1 hunks)
- packages/widget/rollup.config.js (2 hunks)
Files skipped from review due to trivial changes (9)
- .github/workflows/lerna.yaml
- docs/bridge/package.json
- packages/contracts-rfq/package.json
- packages/explorer-ui/package.json
- packages/sdk-router/package.json
- packages/solidity-devops/package.json
- packages/synapse-constants/package.json
- packages/synapse-interface/package.json
- packages/widget/package.json
Additional comments not posted (13)
packages/sdk-router/tsdx.config.js (1)
1-14: LGTM!The configuration for
codecovRollupPluginlooks correct and well-integrated.packages/synapse-interface/next.config.js (1)
Line range hint
2-31: LGTM!The configuration for
codecovWebpackPluginlooks correct and well-integrated.packages/explorer-ui/next.config.js (1)
Line range hint
1-28: LGTM!The configuration for
codecovWebpackPluginlooks correct and well-integrated.packages/widget/rollup.config.js (2)
10-10: Import Statement: Ensure the plugin is necessary.The
codecovRollupPluginis imported from@codecov/rollup-plugin. Ensure this import is necessary and used correctly.
55-59: Codecov Rollup Plugin Configuration: Validate the token and settings.The
codecovRollupPluginis configured withenableBundleAnalysis,bundleName, anduploadToken. Ensure theCODECOV_TOKENis set correctly in the environment and the settings are appropriate for your use case.packages/synapse-constants/webpack.config.js (2)
4-4: Import Statement: Ensure the plugin is necessary.The
codecovWebpackPluginis imported from@codecov/webpack-plugin. Ensure this import is necessary and used correctly.
15-22: Codecov Webpack Plugin Configuration: Validate the token and settings.The
codecovWebpackPluginis configured withenableBundleAnalysis,bundleName, anduploadToken. Ensure theCODECOV_TOKENis set correctly in the environment and the settings are appropriate for your use case..github/workflows/packages.yml (1)
44-47: New Job: Ensure the build job is necessary and correctly configured.A new job
run-buildis added to run builds with theCODECOV_TOKENenvironment variable. Ensure this job is necessary, correctly configured, and the token is securely stored in GitHub secrets..github/workflows/ui-preview.yaml (2)
91-92: Environment Variable: Ensure the token is securely stored.The
CODECOV_TOKENenvironment variable is added for the Vercel deployment step. Ensure the token is securely stored in GitHub secrets.
99-100: Environment Variable: Ensure the token is securely stored.The
CODECOV_TOKENenvironment variable is added for the Vercel production deployment step. Ensure the token is securely stored in GitHub secrets.docs/bridge/docusaurus.config.ts (3)
5-5: Import statement looks good.The import statement for
codecovWebpackPluginappears to be correct.
156-169: Plugin configuration looks good.The
bundle-analyzerplugin is correctly added and configured within thepluginsarray.
161-165: Configuration ofcodecovWebpackPluginlooks good.The plugin is correctly configured with
enableBundleAnalysis,bundleName, anduploadToken. Ensure that the environment variableCODECOV_TOKENis set correctly in the deployment environment.
packages/rest-api/package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| "ci:lint": "npm run lint:check", | |||
| "build:go": " ", | |||
| "build:slither": " ", | |||
| "build": "echo 'please run build api'", | |||
| "build": "npm run build api && echo 'please run build api'", | |||
There was a problem hiding this comment.
Update the build script command.
The build script command appears to be a placeholder and should be updated with the actual build command.
- "build": "npm run build api && echo 'please run build api'",
+ "build": "npm run build:api && <actual-build-command>"Committable suggestion was skipped due to low confidence.
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Configured Codecov Webpack plugin in
/packages/explorer-ui/next.config.jsfor bundle analysis and coverage upload. - Moved
@codecov/webpack-plugintodevDependenciesin/packages/explorer-ui/package.json. - Added Codecov Rollup plugin in
/packages/sdk-router/tsdx.config.jsfor bundle analysis. - Integrated Codecov Webpack plugin in
/packages/synapse-constants/webpack.config.js. - Configured Codecov Webpack plugin in
/packages/synapse-interface/next.config.js. - Updated
/packages/widget/rollup.config.jsto include Codecov Rollup plugin.
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Deploying sanguine-fe with
|
| Latest commit: |
6fad50c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://68770b60.sanguine-fe.pages.dev |
| Branch Preview URL: | https://next-bundle-analyzer.sanguine-fe.pages.dev |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added a new section in
CONTRIBUTING.mdadvisingfetch-depth: 2for shallow clones under 'Github Actions'. - Configured Codecov integration across various packages for enhanced code coverage and bundle analysis.
- Updated multiple workflows and package configurations to include Codecov plugins and environment variables for build and deployment processes.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
docs/bridge/docs/rfq/API/relay-ack.api.mdxto document 'Relay ack' API endpoint - Modified
docs/bridge/docusaurus.config.tsto include Codecov Webpack plugin for bundle analysis - Corrected
baseUrltypo indocs/bridge/docusaurus.config.tsforrfqapiconfiguration
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Modified
packages/rest-api/package.jsonto simplify thebuildscript by removing the 'npm run build api' command.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (15)
- .github/workflows/codeql.yaml (1 hunks)
- .github/workflows/go.yml (5 hunks)
- .github/workflows/lerna.yaml (1 hunks)
- .github/workflows/packages.yml (4 hunks)
- .github/workflows/solidity.yml (1 hunks)
- .github/workflows/ui-preview.yaml (1 hunks)
- CONTRIBUTING.md (1 hunks)
- docs/bridge/docs/rfq/API/relay-ack.api.mdx (1 hunks)
- docs/bridge/docusaurus.config.ts (3 hunks)
- packages/explorer-ui/next.config.js (2 hunks)
- packages/explorer-ui/package.json (1 hunks)
- packages/sdk-router/tsdx.config.js (1 hunks)
- packages/synapse-constants/webpack.config.js (2 hunks)
- packages/synapse-interface/next.config.js (2 hunks)
- packages/widget/rollup.config.js (2 hunks)
Files skipped from review due to trivial changes (6)
- .github/workflows/codeql.yaml
- .github/workflows/go.yml
- .github/workflows/solidity.yml
- CONTRIBUTING.md
- docs/bridge/docs/rfq/API/relay-ack.api.mdx
- packages/synapse-interface/next.config.js
Files skipped from review as they are similar to previous changes (9)
- .github/workflows/lerna.yaml
- .github/workflows/packages.yml
- .github/workflows/ui-preview.yaml
- docs/bridge/docusaurus.config.ts
- packages/explorer-ui/next.config.js
- packages/explorer-ui/package.json
- packages/sdk-router/tsdx.config.js
- packages/synapse-constants/webpack.config.js
- packages/widget/rollup.config.js
Bundle ReportChanges will increase total bundle size by 4.9MB ⬆️
|
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Configured Codecov Rollup plugin in
/packages/sdk-router/tsdx.config.jsfor bundle analysis. - Updated GitHub workflows for improved build and test processes.
- Added
fetch-depth: 2to GitHub Actions for better commit history access. - Integrated Codecov dependencies and scripts in multiple
package.jsonfiles.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Configured Codecov Rollup plugin in
packages/sdk-router/tsdx.config.jsfor bundle analysis - Enabled bundle analysis based on
CODECOV_TOKENenvironment variable - Set bundle name and specified upload token and commit SHA overrides
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- No major changes found since last review.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2836 +/- ##
====================================================
+ Coverage 25.64215% 90.05329% +64.41114%
====================================================
Files 766 58 -708
Lines 54972 1126 -53846
Branches 80 119 +39
====================================================
- Hits 14096 1014 -13082
+ Misses 39429 107 -39322
+ Partials 1447 5 -1442
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Configured bundle analyzer using Codecov plugin in
/packages/synapse-interface/next.config.js - Added Codecov Webpack plugin
- Enabled bundle analysis with
CODECOV_TOKENenvironment variable - Set specific settings for bundle name and upload token
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -22,6 +24,16 @@ const nextConfig = { | |||
| '.json', | |||
| '.nvmrc', | |||
| ] | |||
| config.plugins.push( | |||
| codecovWebpackPlugin({ | |||
| enableBundleAnalysis: process.env.CODECOV_TOKEN !== undefined, | |||
There was a problem hiding this comment.
🧠 logic: Potential issue: Ensure CODECOV_TOKEN is securely managed and not exposed.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (3)
- .github/workflows/packages.yml (4 hunks)
- packages/sdk-router/tsdx.config.js (1 hunks)
- packages/synapse-interface/next.config.js (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/packages.yml
- packages/sdk-router/tsdx.config.js
- packages/synapse-interface/next.config.js
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated bundle name from 'explorer-ui' to 'synapse-interface' in
/packages/synapse-interface/next.config.js - Ensured correct attribution for bundle analysis and coverage reporting
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/synapse-interface/next.config.js (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/synapse-interface/next.config.js
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added documentation for "Relay ack" feature in
/docs/bridge/CHANGELOG.md - Included
CODECOV_TOKENin GitHub Actions workflows in/.github/workflows/scan.yml - Updated
fetch-depthparameter in GitHub Actions workflows in/.github/workflows/scan.yml - Added
@codecov/webpack-pluginand@codecov/rollup-pluginto package configurations in/packages/synapse-interface/tsconfig.json - Updated bundle name from 'explorer-ui' to 'synapse-interface' in
/packages/synapse-interface/next.config.js
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/packages.yml (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/packages.yml
Description
configures analyzer
Summary by CodeRabbit
New Features
codecovWebpackPluginandcodecovRollupPluginacross multiple packages.package.jsonfiles.Chores
CODECOV_TOKENenvironment variable.fetch-depthparameter from1to2in several GitHub Actions workflows.948709f: docs preview link
948709f: explorer-ui preview link
94b5897: docs preview link
f9e12fb: docs preview link
94b5897: synapse-interface preview link
f9e12fb: synapse-interface preview link
f9e12fb: explorer-ui preview link
94b5897: explorer-ui preview link
5125e77: docs preview link
5125e77: synapse-interface preview link
5125e77: explorer-ui preview link
173e7b7: docs preview link
173e7b7: synapse-interface preview link
173e7b7: explorer-ui preview link
ee4c712: docs preview link
ee4c712: synapse-interface preview link
ee4c712: explorer-ui preview link
6d32176: docs preview link
6d32176: synapse-interface preview link
6d32176: explorer-ui preview link